Fixed disallowed_useragent issue for Google authentication on Android#228
Open
marcioferlan wants to merge 1 commit intofullstackreact:masterfrom
Open
Fixed disallowed_useragent issue for Google authentication on Android#228marcioferlan wants to merge 1 commit intofullstackreact:masterfrom
marcioferlan wants to merge 1 commit intofullstackreact:masterfrom
Conversation
|
Hello, please merge this fix! |
ericchan3721
suggested changes
Apr 12, 2021
ericchan3721
left a comment
ericchan3721
left a comment
There was a problem hiding this comment.
Better using the user's actual UserAgent and replace wv from it instead of the hard coded one
mWebView.getSettings().setUserAgentString(mWebView.getSettings().getUserAgentString().replace("; wv", ""));
Ref: https://developers.googleblog.com/2016/08/modernizing-oauth-interactions-in-native-apps.html
P.S. I have open the PR for this issue, however this library seems no longer supported by the original author, you may consider using other OAuth RN library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
This sets the webview User-Agent header to solve the
disallowed_useragentissue for Google authentication on Android.